Skip to content

Commit

Permalink
fix: CI failures with updated BNG/NFsim
Browse files Browse the repository at this point in the history
Two CI failures have crept in with updates to BNG and NFsim.

This first is an error simulating a hybrid particle-population
model in our test suite. This looks like a bug in NFsim 1.14.1,
which generates a segfault on the model which worked in 1.12.1.
I've opened an issue with NFsim for this here:
RuleWorld/nfsim#37

In the meantime, I've pinned the test suite GitHub Actions CI
to NFsim 1.12.1.

The other is a test failure in a BNG model import, which looks
like it's just a consequence of the rule order parsing changing
between BNG versions. I've updated the test to test for the presence
of either of the two expected error messages, both regarding rate
laws.
  • Loading branch information
alubbock committed Feb 28, 2024
1 parent fa9be1a commit eea4098
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/pysb-conda-env.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ channels:
- conda-forge
dependencies:
- alubbock::bionetgen
- alubbock::nfsim==1.12.1
- alubbock::atomizer
- alubbock::kappa
- numpy
Expand Down
3 changes: 2 additions & 1 deletion pysb/tests/test_importers.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ def test_bngl_import_expected_errors():
expected_errors = {'ANx': errtype['plusminus'],
'CaOscillate_Sat': errtype['ratelawtype'],
'heise': errtype['statelabels'],
'isingspin_energy': errtype['ratelawmissing'],
# following model's error differs between BNG versions
'isingspin_energy': f"({errtype['ratelawmissing']})|({errtype['ratelawtype']})",
'test_MM': errtype['ratelawtype'],
'test_sat': errtype['ratelawtype'],
}
Expand Down

0 comments on commit eea4098

Please sign in to comment.