Send usage data in 1-month portions #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch-iara
force-pushed
the
chiara/usage-data-send-portions
branch
from
4240025
to
f1d520a
Compare
jkilpatr
force-pushed
the
chiara/usage-data-send-portions
branch
from
f1d520a
to
02fdaf9
Compare
jkilpatr
requested changes
Jul 27, 2023
There was a problem hiding this comment.
This looks like it works ok but I'm going to insist on some unit tests.
I've also recommended how you can avoid using a self-implemented binary search. You may want to add sorting the usage tracker list to the startup cleanup (where we also remove duplicate hours)
ch-iara
force-pushed
the
chiara/usage-data-send-portions
branch
from
02fdaf9
to
df34ec6
Compare
This change is meant to speed up the checkin loop when routers have a lot of data to upload for usage history. We now only iterate through and send up to a month's worth of hours per checkin.
ch-iara
force-pushed
the
chiara/usage-data-send-portions
branch
2 times, most recently
from
b5c318a
to
20547a7
Compare
ch-iara
force-pushed
the
chiara/usage-data-send-portions
branch
from
20547a7
to
d6da2c1
Compare
jkilpatr
reviewed
Jul 28, 2023
ch-iara
force-pushed
the
chiara/usage-data-send-portions
branch
from
d6da2c1
to
2eafe8f
Compare
jkilpatr
reviewed
Jul 28, 2023
jkilpatr
reviewed
Jul 28, 2023
jkilpatr
reviewed
Jul 28, 2023
jkilpatr
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is meant to speed up the checkin loop when routers have a lot of data to upload for usage history. We now only iterate through and send up to a month's worth of hours per checkin.