Debts test #800
Merged
Debts test #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptulugu
force-pushed
the
pranay/althea_blockchain
branch
2 times, most recently
from
3366189
to
179597d
Compare
ptulugu
force-pushed
the
pranay/althea_blockchain
branch
from
179597d
to
c2b5827
Compare
jkilpatr
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Looks good, my only comment is that it would be nice if the main body of the test where broken into a few functions (only a few things look like they could reused, but it would be nice to have those easily available in their own tests)
I haven't seen this run successfully yet so I still need to watch the test.
ptulugu
force-pushed
the
pranay/althea_blockchain
branch
4 times, most recently
from
a3a0f35
to
8798099
Compare
Debts generated by traffic between two nodes as well as between a node and the internet can be tested by hardcoding an optimal path in code. Current accuracy threshold between calculated debt and the actual debt is set to at least 85% accurate
ptulugu
force-pushed
the
pranay/althea_blockchain
branch
from
8798099
to
a7c22b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debts generated by traffic between two nodes as well as between a node and the internet can be
tested by hardcoding an optimal path in code. Current accuracy threshold between calculated debt
and the actual debt is set to at least 85% accurate