Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ #106

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

_ #106

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2020

_

Thibault Jouan added 6 commits April 2, 2020 15:52
  In 9d09cf5 we inadvertently upgraded Haml to version 5, but middleman
doesn't support it yet:

    Haml::TempleEngine: Option :locals is invalid
    Haml::TempleEngine: Option :outvar is invalid
  This requires using version 4 for `middleman-blog' and
`middleman-favicon-maker' too at the same time, because with current
versions they don't support middleman 4, and their version 4 doesn't
support middleman 3.

bundle update --conservative middleman middleman-blog middleman-favicon-maker middleman-core tilt i18n
  FIXME: with middleman 3 it was builtin, but is considered an optional
extension with middleman 4?
@ghost ghost added bug invalid labels Apr 2, 2020
@ghost ghost self-assigned this Apr 2, 2020
@ghost ghost added wip rebase and removed invalid labels Apr 2, 2020
@ghost ghost removed their assignment Apr 22, 2022
@ghost ghost changed the title Upgrade to middleman 4 _ Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

0 participants