Content change request form tidy up #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The form was changed in #1087 `context` field no loner exists Both reason_for_change and subject_area are required so the conditionals in the helper method are not needed.
It was added in #1087 However the requirements changed and the field was subsequently removed so there is no need to include it in the model.
To address warning: WARN: Job arguments to ZendeskTicketWorker do not serialize to JSON safely. This will raise an error in Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today.
AgaDufrat
force-pushed
the
content-change-request-tidy-up
branch
from
d6ee4af
to
1726bdb
Compare
MuriloDalRi
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work of adding Zendesk mappings but it can be separated from the new feature PR.
See commit messages for details.
Follow these steps if you are doing a Rails upgrade.