Merge pull request #3383 from alphagov/type-module-changes

Drop support for legacy browsers
alphagov · Aug 15, 2024 · c2c448a · c2c448a
2 parents 0ea720b + 51ac2ef
commit c2c448a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -150,7 +150,7 @@ GEM
     govuk_personalisation (0.16.0)
       plek (>= 1.9.0)
       rails (>= 6, < 8)
-    govuk_publishing_components (41.1.1)
+    govuk_publishing_components (42.0.0)
       govuk_app_config
       govuk_personalisation (>= 0.7.0)
       kramdown
@@ -546,10 +546,10 @@ GEM
       rexml (~> 3.2, >= 3.2.5)
       rubyzip (>= 1.2.2, < 3.0)
       websocket (~> 1.0)
-    sentry-rails (5.18.2)
+    sentry-rails (5.19.0)
       railties (>= 5.0)
-      sentry-ruby (~> 5.18.2)
-    sentry-ruby (5.18.2)
+      sentry-ruby (~> 5.19.0)
+    sentry-ruby (5.19.0)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
     shoulda-context (2.0.0)

diff --git a/app/assets/stylesheets/helpers/_old-ie.scss b/app/assets/stylesheets/helpers/_old-ie.scss
@@ -9,7 +9,7 @@
   margin-right: auto;
 }
 
-.js-enabled .govuk-sticky-element--hidden {
+.govuk-frontend-supported .govuk-sticky-element--hidden {
   @include govuk-visually-hidden;
 }
 

diff --git a/app/views/root/_javascript.html.erb b/app/views/root/_javascript.html.erb
@@ -1,4 +1,4 @@
-<%= javascript_include_tag local_assigns[:js_file] || 'application', integrity: false %>
+<%= javascript_include_tag local_assigns[:js_file] || 'application', integrity: false, type: "module" %>
 <% if ENV["DRAFT_ENVIRONMENT"].present? %>
   <%= javascript_include_tag 'modules/base-target', integrity: false %>
 <% end %>