PP-13233: Pre release refactor & features #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t really do that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for the release we went through a code review and broke the app into multiple files. (Thanks @DomBelcher for the input)
I also realised that being naive about the difference between
equalsanddeepEqualshad led me down a path that wouldn't be particularly helpful so I fixed it, we're now respecting the difference. Previously I'd seen query strings being used asequals(allowing additional parameters) and request bodies being used asdeepEquals(not allowing additional properties), as a result I was treating query strings as flexible and bodies as strict which could lead to some false positives in some tests. That's now resolved.This passes the tests and I'm confirming that it's compatible with our apps in the following PRs:
alphagov/pay-selfservice#4281
alphagov/pay-frontend#3910
alphagov/pay-products-ui#2710