Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-12828 Update logging in connector client to only log 5xx responses as errors #3920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PP-12828 Update logging in connector client to only log 5xx responses as errors #3920

wants to merge 1 commit into from

Conversation

DomBelcher
Copy link
Contributor

WHAT

  • Update logging on GET requests to Connector
    • this will only log 5xx responses as errors
    • all other non-200 responses will be logged as warnings

@DomBelcher
PP-12828 Update logging in connector client to only record 5xx respon…
25037c7 
…ses to GET as error, record non-200 responses as warnings
nlsteers
nlsteers approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@nlsteers nlsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlsteers nlsteers nlsteers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DomBelcher @nlsteers