PP-13119 Fix logging of correlation ID to log messages #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqbalgds
force-pushed
the
pp-13119-fix-correlation-id-frontend
branch
from
db906b1
to
d3867f4
Compare
- Remove references to `async local storage`.
- No longer using this as that will be a big change.
- Instead continue to save logging context fields to the request instead.
- Remove all references to `async local storage` - including the
`request-context` file.
- Fix bug where the correlation id was not getting logged and not sent
as a header to backend services.
- When configuring a client that calls the backend - we now pass the
correlation id and save it for each request.
- Pass the correlation id to the backend as a header.
- Log the correlation id as part of logging messages.
- Remove logging messages that are no longer required as the
`pay-js-commons/axios-base-client` will do the logging instead.
iqbalgds
force-pushed
the
pp-13119-fix-correlation-id-frontend
branch
from
d3867f4
to
53cee21
Compare
hjvoid
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async local storage.async local storage- including therequest-contextfile.pay-js-commons/axios-base-clientwill do the logging instead.