Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-10104 payment page validation bugs #3893

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

hjvoid
Copy link
Contributor

@hjvoid hjvoid commented Aug 12, 2024

WHAT

Fixing payment page form validation bugs which do not work as per current Design system. Also added are a <span> tags with a class of "govuk-visually-hidden" as per GOV.UK Design System.

HOW

1st Bug

  1. Go to payment page.
  2. Submit an empty form and the page shows the error summary at the top.
  3. When you click on each one you should be taken to the corresponding input.

2nd Bug

  1. Go to the payment page.
  2. Enter an invalid card number in the card number field.
  3. The error message should appear after the hint text.

3rd Bug

  1. Go to the payment page.
  2. Enter the following invalid card number in the card number field: 4444333322221111aaa
  3. This should show an error.

4th Bug

  1. Go to the payment page
  2. Submit an empty form. The page displays the error summary at the top.
  3. In the card number field, enter an invalid value and then press tab.
  4. The error summary should not be duplicated.

N.B. Will squash on merging.

@hjvoid hjvoid merged commit 8579955 into master Aug 20, 2024
11 checks passed
@hjvoid hjvoid deleted the PP-10104_payment_page_validation_bugs branch August 20, 2024 15:04
iqbalgds pushed a commit that referenced this pull request Sep 16, 2024
Payment page validation UI bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants