PP-12853 Add the charset in Content-Type header for Apple Pay #3886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous PR[1], we have made some progress in communicating with Apple Pay via Axios and HttpsProxyAgent and we have tested that the validation is initiated correctly but then fails with the following message from Apple: `Apple Pay Merchant ID not valid`. See screenshot in the new PR[2]. With this change, we are now adding the charset to the Content-Type header in the post request, in case that is what is expected by Apple Pay, and we are also adding the status to the error log, to have a little bit more information back. Further information in JIRA[3]. [1] #3885 [2] #3886 [3] https://payments-platform.atlassian.net/browse/PP-12853
marcotranchino
force-pushed
the
pp-12853-amendments-for-axios-plus-proxya-agent
branch
from
46931cd
to
c3cc7fe
Compare
SandorArpa
approved these changes
Aug 2, 2024
marcotranchino
deleted the
pp-12853-amendments-for-axios-plus-proxya-agent
branch
marcotranchino
added a commit
that referenced
this pull request
Aug 2, 2024
With the previous PRs[1][2], we have made some progress in communicating with Apple Pay via Axios and HttpsProxyAgent and we have tested that the validation is initiated correctly but then fails with the following message from Apple: `Apple Pay Merchant ID not valid`. See screenshot in the second PR[2]. With this change, we are now passing the certificate and key to the Proxy Agent via additional options. Further information in JIRA[3]. [1] #3885 [2] #3886 [3] https://payments-platform.atlassian.net/browse/PP-12853
marcotranchino
added a commit
that referenced
this pull request
Aug 5, 2024
…axios With the previous PRs[1][2][3], we have made some progress in communicating with Apple Pay via Axios and HttpsProxyAgent and we have tested that the validation is initiated correctly but then fails with the following message: `Apple Pay Merchant ID not valid`. See screenshot in the second PR[2]. With this change, we are now creating the HttpsProxyAgent with just the proxy URL as an argument for its constructor, passing it together with the certificate and key to the HttpsAgent, as arguments for its constructor, and then creating an `axios` instance, passing the HttpsAgent to it. Further information in JIRA[3]. [1] #3885 [2] #3886 [3] #3887 [4] https://payments-platform.atlassian.net/browse/PP-12853
marcotranchino
added a commit
that referenced
this pull request
Aug 5, 2024
…axios With the previous PRs[1][2][3], we have made some progress in communicating with Apple Pay via Axios and HttpsProxyAgent and we have tested that the validation is initiated correctly but then fails with the following message: `Apple Pay Merchant ID not valid`. See screenshot in the second PR[2]. With this change, we are now creating the HttpsProxyAgent with just the proxy URL as an argument for its constructor, passing it together with the certificate and key to the HttpsAgent, as arguments for its constructor, and then creating an `axios` instance, passing the HttpsAgent to it. Further information in JIRA[3]. [1] #3885 [2] #3886 [3] #3887 [4] https://payments-platform.atlassian.net/browse/PP-12853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous PR[1], we have made some progress in communicating with Apple Pay via Axios and HttpsProxyAgent and we have tested that the validation is initiated correctly but then fails with the following message from Apple:
Apple Pay Merchant ID not valid.See screenshot in the new PR[2].
With this change, we are now adding the charset to the Content-Type header in the post request, in case that is what is expected by Apple Pay, and we are also adding the status to the error log, to have a little bit more information back.
Further information in JIRA[3].
[1]
#3885
[2]
#3886
[3]
https://payments-platform.atlassian.net/browse/PP-12853
SCREENSHOT