PP-12546 remove csrf secret from charge objects #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlsteers
force-pushed
the
pp-12546/remove-charge-csrf-secrets
branch
from
482a03a
to
e140237
Compare
this change is part of a wider series that are being merged in sequence to prevent the need for a downtime deployment - do not set charge level csrf secret - do not validate tokens against charge level csrf secret - update tests to reflect new behaviour
nlsteers
force-pushed
the
pp-12546/remove-charge-csrf-secrets
branch
from
e140237
to
1c1111f
Compare
alexbishop1
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
this change is part of a wider series that are being merged in sequence to prevent the need for a downtime deployment