Card number validation if not numerical or a space

alphagov · Aug 12, 2024 · e9fd7f6 · e9fd7f6
1 parent 6e39a67
commit e9fd7f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/utils/charge-validation-fields.js b/app/utils/charge-validation-fields.js
@@ -155,7 +155,8 @@ function containsSuspectedCVV (input) {
 
 // Must be bound prior to use
 function cardNo (cardNo) {
-  if (!cardNo) return 'message' // default message
+  const numbersAndSpacesOnly = /^[\d ]+$/;
+  if (!cardNo || !numbersAndSpacesOnly.test(cardNo)) return 'message' // default message
   cardNo = cardNo.replace(/\D/g, '')
   const cardType = creditCardType(cardNo)
   if (!cardNo || cardNo.length < 12 || cardNo.length > 19) return 'numberIncorrectLength'

diff --git a/test/utils/charge-validation-fields/card-number-field-validation.test.js b/test/utils/charge-validation-fields/card-number-field-validation.test.js
@@ -9,9 +9,9 @@ describe('card validation: card number', function () {
     expect(result).to.equal(true)
   })
 
-  it('should strip non numbers', function () {
+  it('should return invalid if cardNo contains non-numbers', function () {
     const result = fields.fieldValidations.cardNo('42424242424242dsakljl42')
-    expect(result).to.equal(true)
+    expect(result).to.equal('message')
   })
 
   it('should return incorrect length', function () {