-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use axios or request retry for Apple Pay Merchant validation
With this change, we are introducing a new environment variable to check whether the pay-frontend application should use axios for the Apple Pay Merchant Validation. By default the new variable will not exist on any environment, therefore pay-frontend will keep using request retry to operate the Apple Pay Merchant Validation. When the new variable is created and set to true, then pay-frontend will use Axios, with or without the use of HttpsProxyAgent, in order to operate the Apple Pay Merchant Validation. This will allow us to safely deploy this change to all environments including production, and crucially it will allow us to test the Apple Pay Merchant Validation using axios on the Test environment only by creating the new environment variable there and setting it to 'true'. Further work will be needed to remove the old code and the use of request retry once the validation will be successfully operated with axios in all environments. Note that for simplicity the old tests for the Apple Pay Merchant Validation using request retry have been saved in a new file called old-merchant-validation.controller.test.js, so that it will be easy to simply delete this file once the current way using request retry will be fully discontinued. Further information in Jira. https://payments-platform.atlassian.net/browse/PP-12853
- Loading branch information
1 parent
b088df5
commit 3dfbcbe
Showing
4 changed files
with
260 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
184 changes: 184 additions & 0 deletions
184
test/controllers/web-payments/apple-pay/old-merchant-validation.controller.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| 'use strict' | ||
|
|
||
| const sinon = require('sinon') | ||
| const proxyquire = require('proxyquire') | ||
|
|
||
| const merchantDomain = 'www.pymnt.uk' | ||
| const worldpayMerchantId = 'worldpay.merchant.id' | ||
| const worldpayCertificate = 'A-WORLDPAY-CERTIFICATE' | ||
| const worldpayKey = 'A-WORLDPAY-KEY' | ||
| const stripeMerchantId = 'stripe.merchant.id' | ||
| const stripeCertificate = 'A-STRIPE-CERTIFICATE' | ||
| const stripeKey = 'A-STRIPE-KEY' | ||
| const url = 'https://fakeapple.url' | ||
|
|
||
| const oldAppleResponse = { status: 200 } | ||
| const oldAppleResponseBody = { foo: 'bar' } | ||
|
|
||
| function getControllerWithMocks (requestMock) { | ||
| return proxyquire('../../../../app/controllers/web-payments/apple-pay/merchant-validation.controller', { | ||
| requestretry: requestMock | ||
| }) | ||
| } | ||
|
|
||
| describe('Validate with Apple the merchant is legitimate', () => { | ||
| let res, sendSpy | ||
|
|
||
| beforeEach(() => { | ||
| process.env.APPLE_PAY_MERCHANT_DOMAIN = merchantDomain | ||
| process.env.WORLDPAY_APPLE_PAY_MERCHANT_ID = worldpayMerchantId | ||
| process.env.WORLDPAY_APPLE_PAY_MERCHANT_ID_CERTIFICATE = worldpayCertificate | ||
| process.env.WORLDPAY_APPLE_PAY_MERCHANT_ID_CERTIFICATE_KEY = worldpayKey | ||
| process.env.STRIPE_APPLE_PAY_MERCHANT_ID = stripeMerchantId | ||
| process.env.STRIPE_APPLE_PAY_MERCHANT_ID_CERTIFICATE = stripeCertificate | ||
| process.env.STRIPE_APPLE_PAY_MERCHANT_ID_CERTIFICATE_KEY = stripeKey | ||
| process.env.APPLE_PAY_MERCHANT_VALIDATION_VIA_AXIOS = 'false' | ||
|
|
||
| sendSpy = sinon.spy() | ||
| res = { | ||
| status: sinon.spy(() => ({ send: sendSpy })), | ||
| sendStatus: sinon.spy() | ||
| } | ||
| }) | ||
|
|
||
| it('should return a payload for a Worldpay payment if Merchant is valid', async () => { | ||
| const mockRequest = sinon.stub().yields(null, oldAppleResponse, oldAppleResponseBody) | ||
| const controller = getControllerWithMocks(mockRequest) | ||
|
|
||
| const req = { | ||
| body: { | ||
| url, | ||
| paymentProvider: 'worldpay' | ||
| } | ||
| } | ||
| await controller(req, res) | ||
|
|
||
| sinon.assert.calledWith(mockRequest, { | ||
| url, | ||
| body: { | ||
| merchantIdentifier: worldpayMerchantId, | ||
| displayName: 'GOV.UK Pay', | ||
| initiative: 'web', | ||
| initiativeContext: merchantDomain | ||
| }, | ||
| method: 'post', | ||
| json: true, | ||
| cert: `-----BEGIN CERTIFICATE----- | ||
| ${worldpayCertificate} | ||
| -----END CERTIFICATE-----`, | ||
| key: `-----BEGIN PRIVATE KEY----- | ||
| ${worldpayKey} | ||
| -----END PRIVATE KEY-----` | ||
| }) | ||
| sinon.assert.calledWith(res.status, 200) | ||
| sinon.assert.calledWith(sendSpy, oldAppleResponseBody) | ||
| }) | ||
|
|
||
| it('should return a payload for a Stripe payment if Merchant is valid', async () => { | ||
| const mockRequest = sinon.stub().yields(null, oldAppleResponse, oldAppleResponseBody) | ||
| const controller = getControllerWithMocks(mockRequest) | ||
|
|
||
| const req = { | ||
| body: { | ||
| url, | ||
| paymentProvider: 'stripe' | ||
| } | ||
| } | ||
| await controller(req, res) | ||
|
|
||
| sinon.assert.calledWith(mockRequest, { | ||
| url, | ||
| body: { | ||
| merchantIdentifier: stripeMerchantId, | ||
| displayName: 'GOV.UK Pay', | ||
| initiative: 'web', | ||
| initiativeContext: merchantDomain | ||
| }, | ||
| method: 'post', | ||
| json: true, | ||
| cert: `-----BEGIN CERTIFICATE----- | ||
| ${stripeCertificate} | ||
| -----END CERTIFICATE-----`, | ||
| key: `-----BEGIN PRIVATE KEY----- | ||
| ${stripeKey} | ||
| -----END PRIVATE KEY-----` | ||
| }) | ||
| sinon.assert.calledWith(res.status, 200) | ||
| sinon.assert.calledWith(sendSpy, oldAppleResponseBody) | ||
| }) | ||
|
|
||
| it('should return 400 if no url is provided', async () => { | ||
| const mockRequest = sinon.stub().yields(null, oldAppleResponse, oldAppleResponseBody) | ||
| const controller = getControllerWithMocks(mockRequest) | ||
|
|
||
| const req = { | ||
| body: { | ||
| paymentProvider: 'worldpay' | ||
| } | ||
| } | ||
| await controller(req, res) | ||
| sinon.assert.calledWith(res.sendStatus, 400) | ||
| }) | ||
|
|
||
| it('should return a payload for a Sandbox payment if Merchant is valid', async () => { | ||
| const mockRequest = sinon.stub().yields(null, oldAppleResponse, oldAppleResponseBody) | ||
| const controller = getControllerWithMocks(mockRequest) | ||
|
|
||
| const req = { | ||
| body: { | ||
| url, | ||
| paymentProvider: 'sandbox' | ||
| } | ||
| } | ||
| await controller(req, res) | ||
|
|
||
| sinon.assert.calledWith(mockRequest, { | ||
| url, | ||
| body: { | ||
| merchantIdentifier: worldpayMerchantId, | ||
| displayName: 'GOV.UK Pay', | ||
| initiative: 'web', | ||
| initiativeContext: merchantDomain | ||
| }, | ||
| method: 'post', | ||
| json: true, | ||
| cert: `-----BEGIN CERTIFICATE----- | ||
| ${worldpayCertificate} | ||
| -----END CERTIFICATE-----`, | ||
| key: `-----BEGIN PRIVATE KEY----- | ||
| ${worldpayKey} | ||
| -----END PRIVATE KEY-----` | ||
| }) | ||
| sinon.assert.calledWith(res.status, 200) | ||
| sinon.assert.calledWith(sendSpy, oldAppleResponseBody) | ||
| }) | ||
|
|
||
| it('should return 400 for unexpected payment provider', async () => { | ||
| const mockRequest = sinon.stub().yields(null, oldAppleResponse, oldAppleResponseBody) | ||
| const controller = getControllerWithMocks(mockRequest) | ||
|
|
||
| const req = { | ||
| body: { | ||
| url, | ||
| paymentProvider: 'mystery' | ||
| } | ||
| } | ||
| await controller(req, res) | ||
| sinon.assert.calledWith(res.sendStatus, 400) | ||
| }) | ||
|
|
||
| it('should return an error if Apple Pay returns an error', async () => { | ||
| const mockRequest = sinon.stub().yields(new Error(), oldAppleResponse, oldAppleResponseBody) | ||
| const controller = getControllerWithMocks(mockRequest) | ||
|
|
||
| const req = { | ||
| body: { | ||
| url, | ||
| paymentProvider: 'worldpay' | ||
| } | ||
| } | ||
| await controller(req, res) | ||
| sinon.assert.calledWith(res.status, 500) | ||
| sinon.assert.calledWith(sendSpy, oldAppleResponseBody) | ||
| }) | ||
| }) |