PP-12240: Card length validation matches CARD_RANGE_LENGTH

[nataliecarey]

WHAT YOU DID

I used CARD_RANGE_LENGTH to define the minimum length for the card number as any card number shorter than this leads to a 404 even if the range is correct.

How to test

• Pick a bin range from a CSV that's shorter than the maximum (currently 11) (e.g. 71221111 from src/test/resources/card-id-resource-integration-test/test-bin-ranges.csv)
• Make requests with different numbers of zeros on the end of the prefix e.g. 71221111, then 712211110, then 7122111100

Expectation: The first requests should give validation failures (422 status code), then when they pass validation they should be found (200 status code), if you continue to make them longer you'll reach another validation failure (422 status code).

Current reality: The first requests should give validation failures (422 status code), then when they pass validation then when you reach 10 characters it will pass validation but fail to find the card (404 status code), then adding one more zero leads to it being found (200 status code), if you continue to make them longer you'll reach another validation failure (422 status code).

Code review checklist

Logging

• No logging has been added as the validation already existed, it's just been updated

Documentation

• No changes to the documentation as it already explains about updating the CARD_RANGE_LENGTH and already implies that no other change is needed - with this PR no other change is needed (AFAICT).

[nlsteers]

Looks good, one small comment

[nlsteers]

this test is very similar to the one above, you can parameterise these to DRY this up a bit

[nataliecarey]

Updated, thanks.

[nlsteers]

🚀