GA4: Fix ecommerce tracking of searches without query #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
approved these changes
Oct 18, 2024
|
Needs a CHANGELOG entry probably 👍 |
The GA4 ecommerce tracking for search results doesn't currently work if the user is searching for an empty query, as the check for whether the `ga4-search-query` data attribute is present uses loose Javascript boolean logic (i.e. returning false for an empty string). This amends it to strictly check for `null` instead (data attribute not present at all), and adds some tests for the search ecommerce data being properly set with the query present and absent.
csutter
force-pushed
the
fix-search-ecomm
branch
from
80a89f2
to
a5e958d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The GA4 ecommerce tracking for search results doesn't currently work if the user is searching for an empty query, as the check for whether the
ga4-search-querydata attribute is present uses loose Javascript boolean logic (i.e. returning false for an empty string).This amends it to strictly check for
nullinstead (data attribute not present at all), and adds some tests for the search ecommerce data being properly set with the query present and absent.Why
So we can actually track empty searches like all other searches.