Bedrock basic answer strategy #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindew
reviewed
Jan 30, 2025
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
26279fd to
c75e7f0
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
c75e7f0 to
6442a60
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
6442a60 to
e1bd956
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
f1cc88e to
09bdd47
Compare
kevindew
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Looks great Chae, sorry for taking a while to get this review together.
I think the other thing to add which we discussed was a system test similar to https://github.com/alphagov/govuk-chat/blob/main/spec/system/conversation_with_open_ai_with_structured_answer_spec.rb
lib/answer_composition/pipeline/bedrock_structured_answer_composer.rb
Outdated
Show resolved
Hide resolved
lib/answer_composition/pipeline/bedrock_structured_answer_composer.rb
Outdated
Show resolved
Hide resolved
spec/lib/answer_composition/pipeline/bedrock_structured_answer_composer_spec.rb
Outdated
Show resolved
Hide resolved
lib/answer_composition/pipeline/bedrock_structured_answer_composer.rb
Outdated
Show resolved
Hide resolved
spec/lib/answer_composition/pipeline/bedrock_structured_answer_composer_spec.rb
Outdated
Show resolved
Hide resolved
spec/lib/answer_composition/pipeline/bedrock_structured_answer_composer_spec.rb
Outdated
Show resolved
Hide resolved
spec/lib/answer_composition/pipeline/bedrock_structured_answer_composer_spec.rb
Outdated
Show resolved
Hide resolved
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
09bdd47 to
cdd74c1
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
cdd74c1 to
e7a2a7e
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
7589e94 to
1cd13cb
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
1cd13cb to
e824b5c
Compare
kevindew
reviewed
Feb 3, 2025
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
e824b5c to
f166e5f
Compare
kevindew
force-pushed
the
bedrock-basic-answer-strat
branch
from
1fe111c to
6b5c3a7
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
6b5c3a7 to
df027e7
Compare
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
df027e7 to
54fb7ce
Compare
chaecramb
changed the title
Changes the approach to setting the answer strategy when a new Question is created to now be configured via an env var. Currently this defaults to `openai_structured_answer`, but allows for the creation of an `ANSWER_STRATEGY` variable in `.env` which can be set to `"claude_structured_answer"` in order to switch to using Claude via Bedrock as an answer service.
The `OpenAIAnswer` class has minimal code that is specific to OpenAI so has been renamed to the more generic `PipelineRunner`. This class will be used to execute the pipeline regardless of which answer service is configured by the answer strategy. Currently catches errors separately for both OpenAI and AWS, but these may be abstracted in the future.
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
54fb7ce to
f90e696
Compare
jackbot
reviewed
Feb 5, 2025
lib/answer_composition/pipeline/claude/structured_answer_composer.rb
Outdated
Show resolved
Hide resolved
Creates a `StructuredAnswerComposer` class for Claude that makes use of the AWS BedrockRuntime SDK to use Claude as an answer service. In order to force a JSON output from Claude it uses a tool call, this is configured to always be used via the `tool_choice` configuration option for the Bedrock request.
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
f90e696 to
6271202
Compare
kevindew
reviewed
Feb 6, 2025
This sets up testing for the Claude structured answer composer. It creates an initial set of tests. It also creates a set of helpers in StubBedrock. The helpers include a general task to stub the Bedrock converse endpoint, and then high and low level tasks for stubbing the Claude tool call responses.
This creates system tests for a conversation with Claude using structured answers. It also adds a new system spec helper to allow a scenario where Rails configuration is set to use Claude as an answer strategy.
chaecramb
force-pushed
the
bedrock-basic-answer-strat
branch
from
6271202 to
40b1146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a basic answer strategy using Claude 3.5 Sonnet on Bedrock. In this initial implementation we simply have Claude provide a structured JSON response directly, without rephrasing, guardrails or RAG.
It does four things:
OpenAIAnswerclass to a more genericPipelineRunnerclass, this can be used to run the pipeline for both Claude and OpenAI.StructuredAnswerComposerfor Claude that returns a JSON response via a tool call.Trello: https://trello.com/c/wB5dUyQ7/2257-integrate-a-very-basic-answer-strategy-no-rag-with-aws-bedrock