Replace title components with heading components #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update templates to call the heading component; update presenters (rename instances of TitleAndContext/title_and_context to HeadingAndContext/heading_and_context; replace t.delete(:average_title_length) with t[:font_size] = 'xl' (average_title_length is used by the title component to set either a large or extra large font size of the heading however the heading component does not use this option. Therefore, we directly set the heading size to large in heading_and_context.rb and use the override seen here when we want an extra large font size); update/fix tests)
This reinstates spacing that was introduced by the title component (and also the main element should have this class anyway). The class is excluded from html_publication, worldwide_corporate_information, worldwide_office, and worldwide_organisation templates as it introduces too much spacing. Additionally, using the 'govuk-main-wrapper' class makes the instances of 'responsive-top-margin' redundant as the latter now introduces excess spacing. Therefore they have been removed.
During testing, I noticed this margin top override was now introducing unnecessary spacing after implementing the 'govuk-main-wrapper' class in the previous commit, and therefore I've removed it.
KludgeKML
approved these changes
Feb 19, 2025
JamesCGDS
deleted the
replace_title_components_with_heading_components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
This PR replaces instances of the title component with the heading component.
Why
Trello card
Visual changes
There is a very small decrease in spacing above the heading on larger screen sizes due to introducing the
govuk-main-wrapperclass on themainelement to handle spacing. On smaller screen sizes, spacing has been introduced above the heading where it didn't exist before (screenshots below).Due to the very small difference on larger screens and the benefit of additional spacing on smaller screens, I'd argue these changes aren't a blocker. Happy to discuss though.