Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component wrapper on figure component #3532

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 23, 2025

What

  • Adds the component wrapper to the figure component.
  • I've already done this in: Use component wrapper on figure component frontend#4599 The navigation team have given me the OK to add the wrapper in this repo too, and they will investigate if this component needs to be consolidated later.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@AshGDS AshGDS self-assigned this Jan 23, 2025
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3532 January 23, 2025 11:06 Inactive
@AshGDS AshGDS force-pushed the add-component-wrapper-to-more-components branch from 0e2e39d to b493bb6 Compare January 23, 2025 11:16
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3532 January 23, 2025 11:17 Inactive
@AshGDS AshGDS requested a review from andysellick January 23, 2025 11:28
@AshGDS AshGDS merged commit 1503b29 into main Jan 23, 2025
11 checks passed
@AshGDS AshGDS deleted the add-component-wrapper-to-more-components branch January 23, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants