Add document_type and schema_name to prom labels #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardTowers
force-pushed
the
prometheus-labels-for-content-type
branch
from
8ca0b78 to
901c75b
Compare
This results in metrics like:
http_requests_total{action="show",controller="content_items",document_type="answer",schema_name="answer",status="200"} 1
This will allow us to investigate the performance of different content
types, for example how long does it take to load a manual vs. an answer
or a case_study. Currently we can't distinguish these in the metrics for
government-frontend, because it uses the same controller action for all
content types.
If there are some content types which take a much longer time to load,
maybe there are performance issues we should address.
This follows on from alphagov/govuk_app_config#424
which adds the functionality to support setting prometheus labels in this way.
richardTowers
force-pushed
the
prometheus-labels-for-content-type
branch
from
901c75b to
d23fcf0
Compare
theseanything
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to investigate the performance of different content types, for example how long does it take to load a manual vs. an answer or a case_study.
If there are some content types which take a much longer time to load, maybe there are performance issues we should address.
This follows on from alphagov/govuk_app_config#424 which adds the functionality to support setting prometheus labels in this way.