Fix hmrc manuals heading #3464
Merged
Fix hmrc manuals heading #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinailie
force-pushed
the
draft-fix-hmrc-manuals-heading
branch
from
9a63bf7 to
2b11ac3
Compare
catalinailie
force-pushed
the
draft-fix-hmrc-manuals-heading
branch
from
2b11ac3 to
aef9c9d
Compare
catalinailie
force-pushed
the
draft-fix-hmrc-manuals-heading
branch
from
aef9c9d to
6916dc3
Compare
catalinailie
force-pushed
the
draft-fix-hmrc-manuals-heading
branch
from
6916dc3 to
7a242d2
Compare
catalinailie
force-pushed
the
draft-fix-hmrc-manuals-heading
branch
from
7a242d2 to
4379865
Compare
| @@ -13,7 +13,7 @@ | |||
| <% @content_item.section_groups.each do |group| %> | |||
| <% next unless group["child_sections"].present? %> | |||
| <div class="subsection-collection"> | |||
| <%= render "content_items/manuals/hmrc_sections", group: group %> | |||
| <%= render "content_items/manuals/hmrc_sections", group: group, heading: 3 %> | |||
There was a problem hiding this comment.
non-blocking: heading could be updated to heading_level to help make it more descriptive of what it is used for, example of this approach in frontend - https://github.com/alphagov/frontend/blob/e897dc6675d8c02118be82ff08d20b92d84d7437/app/views/landing_page/blocks/_heading.html.erb#L13
MartinJJones
approved these changes
Jan 16, 2025
catalinailie
force-pushed
the
draft-fix-hmrc-manuals-heading
branch
from
4379865 to
6a35c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of HMRC manual section pages:
Before:
After:
Example of HMRC manual pages:
Before:
After:
Trello card: https://trello.com/c/siEO6N64/3097-hmrc-manuals-api-section-headings-issue-l#