Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance on working with AWS accounts #862

Merged

Conversation

stephengrier
Copy link
Contributor

@stephengrier stephengrier commented Nov 24, 2023

Move guidance on working with AWS accounts from the defunct Reliability Engineering wiki to the GDS Way. The guidance is still is use by those requesting new AWS accounts or user access.

Move guidance on working with AWS accounts from the defunct Reliability
Engineering wiki to the GDS Way. The guidance is still is use by those
requesting new AWS accounts or user access.
deanwilson
deanwilson previously approved these changes Nov 28, 2023
Copy link
Collaborator

@deanwilson deanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away

Copy link
Member

@huwd huwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a helpful change, I think it could resolve @galund's point then this could merge?

source/manuals/working-with-aws-accounts.html.md.erb Outdated Show resolved Hide resolved
The Working with AWS accounts guidance does not apply to the One Login directorate as it has its own AWS organisation, so update the guidance to make this clear.

Co-authored-by: huw <[email protected]>
galund
galund previously approved these changes Feb 21, 2024
Copy link
Contributor

@galund galund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

source/manuals/working-with-aws-accounts.html.md.erb Outdated Show resolved Hide resolved
source/manuals/working-with-aws-accounts.html.md.erb Outdated Show resolved Hide resolved
source/manuals/working-with-aws-accounts.html.md.erb Outdated Show resolved Hide resolved
source/manuals/working-with-aws-accounts.html.md.erb Outdated Show resolved Hide resolved
source/manuals/working-with-aws-accounts.html.md.erb Outdated Show resolved Hide resolved
Add a few changes suggested by @galund following code review. Improve a few image alt texts; remove a duplicated line referring to removing users; and fix some spellings introduced in the last commit.

Co-authored-by: George Lund <[email protected]>
@stephengrier stephengrier merged commit 69d685c into main Feb 21, 2024
1 check passed
@stephengrier stephengrier deleted the stephengrier/add_working-with-aws-accounts_guidance branch February 21, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants