Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip external link check during CI on main branch #848

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

robinjam
Copy link
Contributor

@robinjam robinjam commented Nov 2, 2023

This commit splits building and testing external links into two separate actions, and skips the link checker for builds on the main branch.

This ensures that the main branch is always in a deployable state, even if it contains broken links (for example, if it contains new files that have self-referential links within them, as is the state of this repo right now).

Note that CI is expected to fail for this PR. The issue should go away after the next successful deploy, in the meantime we will need to merge this PR bypassing the status check.

This commit splits building and testing external links into two separate actions, and skips the link checker for builds on the main branch.

This ensures that the main branch is always in a deployable state, even if it contains broken links.
@robinjam robinjam changed the title Skip checking of external links on main branch Skip external link check during CI on main branch Nov 2, 2023
@robinjam robinjam marked this pull request as ready for review November 2, 2023 15:36
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@robinjam robinjam merged commit 34cd800 into main Nov 2, 2023
1 check failed
@robinjam robinjam deleted the skip-link-checks-on-main branch November 2, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants