Skip to content

Commit

Permalink
BAU: Pull-request feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mrwilson committed Apr 27, 2023
1 parent 0d436ed commit 219cc1a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion source/partials/_nav-version-control-deployments.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<ul>
<li><a href="/standards/source-code/">How to store source code</a></li>
<li><a href="/standards/source-code/index.html">How to store source code</a></li>
<li><a href="/standards/pull-requests.html">Using Pull Requests</a></li>
<li><a href="/manuals/readme-guidance.html">Writing READMEs</a></li>
Expand Down
2 changes: 1 addition & 1 deletion source/standards/optimise-frontend-perf.html.md.erb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ For example:
|---|---|---|
|#High|Position styles correctly|Set styles at the top of the page and `defer` scripts |
||Minimise HTTP requests|Minimise tiling icons, CSS and JavaScript files to reduce size and loading time [HTTP/1.1 only]|
||Compress static resources|Use minification, [Gzip][], and [Brotli][] to compress CSS and JavaScript code|
||Compress static resources|Use [minification][], [Gzip][], and [Brotli][] to compress CSS and JavaScript code|
||Set correct Headers|Set correct [Cache-Control][] and [ETag][] headers on assets for optimal caching|
|#Medium|Look for empty image `src` attributes|Avoid using empty image `src` attributes as some browsers always send requests to them, resulting in additional traffic|
||Include `width` and `height` attributes on images to minimise layout thrashing | Make sure to include these attributes to improve visual stability and the [Cumulative Layout Shift (CLS)][] metric
Expand Down
2 changes: 1 addition & 1 deletion source/standards/principle-least-access.html.md.erb
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ If you’re using the gds-users account to log into your AWS accounts, you shoul
- [NCSC - privileged user management](https://www.ncsc.gov.uk/guidance/introduction-identity-and-access-management#section_6)
- [NCSC - preventing lateral movement][polp]

[polp]: https://www.ncsc.gov.uk/guidance/preventing-lateral-movement
[polp]: https://csrc.nist.gov/Projects/risk-management/sp800-53-controls/release-search#6

0 comments on commit 219cc1a

Please sign in to comment.