Erb lint update #1782
Merged
Erb lint update #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -19,7 +19,7 @@ | |||
| <% end %> | |||
|
|
|||
| <h4> | |||
| <%= link_to content_item.title, content_item.url, data: {proxy_iframe: 'enabled', modal_url: content_item.proxied_url, toggle: 'modal', target: '#iframe_modal_id'} %> | |||
| <%= link_to content_item.title, content_item.url, data: {proxy_iframe: "enabled", modal_url: content_item.proxied_url, toggle: "modal", target: "#iframe_modal_id"} %> | |||
Check notice
Code scanning / Brakeman
Potentially unsafe model attribute in link_to href. Note
There was a problem hiding this comment.
I believe we can dismiss this brakeman alert here as its not caused by lint changes and ignore later.
There was a problem hiding this comment.
I think that's what the update to the brakeman.ignore fils is supposed to achieve?
Line only updated for erb linting Safe to still ignore
mtaylorgds
reviewed
Sep 4, 2024
Correct indendation issue from linting Make Gem require: false Brakeman ignore file updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in most(may be all) of our app there is no linting mechanism for erb files. We want some way of linting erb files and hence we have introduced erb_lint gem for the same.
The changes in this PR allows us to have a workflow to run erb lint.
All the files that have been linted after running erblint.
When we run the command 'erblint --lint-all' it uses the default '.erb_lint.yml' file inside the project to apply any custom rules.
https://trello.com/c/NPZL0Ibg