Migrate to dart sass #1763
Merged
Migrate to dart sass #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
migrate-to-dart-sass
branch
3 times, most recently
from
9912b91
to
b41be76
Compare
andysellick
force-pushed
the
migrate-to-dart-sass
branch
2 times, most recently
from
287de21
to
b959f11
Compare
- Create `dartsass.builds` initializer and add all Sass files to be compiled. See https://github.com/rails/dartsass-rails#configuring-builds - Create .keep - Update manifest file to use /builds directory - Ignore /builds
- Also, turn digests off in development
andysellick
force-pushed
the
migrate-to-dart-sass
branch
from
b959f11
to
5cf01e8
Compare
MartinJJones
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrate to dart sass from lib sass.
Note that this change relies on alphagov/govuk-docker#768 for local development.
Relates to alphagov/govuk_publishing_components#4106
Why
All applications using
govuk_publishing_componentsshould be using dart sass, and some changes coming in that gem may cause errors if applications aren't using dart sass.Visual changes
None.
Trello card: https://trello.com/c/gW2NW1sB/239-fix-sass-compilation-warnings