Upgrade to govuk_publishing_components 43.1.1

[lauraghiorghisor-tw]

This is effectively an upgrade to GOV.UK Frontend 5.

This is another attempt at making the upgrade. We've just reverted in PR #1467.
Current changes include replacing Uglifier with Terser as per the documentation here.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

[ChrisBAshton]

Thanks for picking this up! One suggestion below.

Aside from that, is there a way we can get CI to fail without the switch to Terser? I'd have more confidence in the PR if we could see CI fail (before merge), and then fix it by switching to Terser, rather than making the changes up front and hoping it'll work.

[lauraghiorghisor-tw]

Thanks for picking this up! One suggestion below.

Aside from that, is there a way we can get CI to fail without the switch to Terser? I'd have more confidence in the PR if we could see CI fail (before merge), and then fix it by switching to Terser, rather than making the changes up front and hoping it'll work.

We saw this Uglifier::Error in the failure here.

On a more general note, though, that should have failed the PR checks too, no? I imagine both the PR checks and the CI are the same script, running in a very similar set-up. Whilst I can understand a flaky test passing the PR checks and then failing when we merge in, this error here does not strike me as a potentially flaky one. Rather odd, and we're seeing similar stuff in WH (though in that case I think tests are just flaky).

[ChrisBAshton]

@lauraghiorghisor-tw that's what I mean - I'd like the PR check to fail, rather than us finding out it's broken only after merge when it's trying to deploy 😅

We could probably add something like rails assets:precompile to https://github.com/alphagov/contacts-admin/blob/main/.github/workflows/rspec.yml 🙏

[lauraghiorghisor-tw]

@lauraghiorghisor-tw that's what I mean - I'd like the PR check to fail, rather than us finding out it's broken only after merge when it's trying to deploy 😅

We could probably add something like rails assets:precompile to https://github.com/alphagov/contacts-admin/blob/main/.github/workflows/rspec.yml 🙏

Seems like that's already running as part of rspec.yml. See

contacts-admin/.github/workflows/rspec.yml

Line 49 in a4c5044

- name: Precompile assets

[lauraghiorghisor-tw]

Shall we just merge? @ChrisBAshton 🤔

[ChrisBAshton]

Try a branch deploy of upgrade-to-frontend-5 first maybe? But yes, good to go 👍