Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for using content_id for matching list items #2223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Jul 25, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Prepare for another PR which relates to using content_id instead of base_path for matching list items. This PR adds a new database column which will store content_id. After the database is migrated is it necessary to run the rake task which will fill in the new column.

Previously content_id was retrieved dynamically from publishing-api. The rake task uses exactly the same mechanism to retrieve and store new content ids.

The rake task can be removed after it does its job in all environments.

Why

Trello ticket

@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch from f93782b to 7e1a7dd Compare July 25, 2024 15:48
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch 3 times, most recently from a63c7bf to 5204e9a Compare July 26, 2024 09:27
@unoduetre unoduetre marked this pull request as ready for review July 26, 2024 11:41
@unoduetre unoduetre requested a review from baisa July 26, 2024 11:41
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch from 5204e9a to 7830553 Compare July 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant