-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list of changes since last release in the CHANGELOG #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d486298
to
ad96708
Compare
romaricpascal
commented
Feb 22, 2024
- [Pull request #496: Handle query change when the text length does not change](https://github.com/alphagov/accessible-autocomplete/pull/496) (merged through [pull request #621](https://github.com/alphagov/accessible-autocomplete/pull/621)). Thanks to @archferns for contributing this change. | ||
- [Pull request #591: Add `menuAttributes` to fix Axe's 'aria-input-field-name' error](https://github.com/alphagov/accessible-autocomplete/pull/591). Thanks to @mchughbri for contributing this change. | ||
- [Pull request #600: Fix null aria attributes](https://github.com/alphagov/accessible-autocomplete/pull/600). Thanks to @mark-roberts-ho for contributing this change. | ||
- [Pull request #606: Correct description of tStatusSelectedOption i18n option in README and tweak some wording for consistency with other parts of the README](https://github.com/alphagov/accessible-autocomplete/pull/606). Thanks to @ellamdav for contributing this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a docs fix, rather than a code fix, but it felt important to acknowledge that kind of contribution as well.
romaricpascal
commented
Feb 22, 2024
8759d79
to
bc3a54e
Compare
bc3a54e
to
e2a44e2
Compare
claireashworth
approved these changes
Feb 23, 2024
e2a44e2
to
80ebd6c
Compare
Co-authored-by: CAAshworth <[email protected]>
80ebd6c
to
30497a9
Compare
@claireashworth Looks like I missed a couple of things for the breaking changes, sorry:
Would you be able to give another look, please? 😊 |
claireashworth
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I collected all the revelant pull requests merged since the last release.
Closes #624.