Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProverClient Refactor: Remove ClStfRange and integrate derive_l1_range #709

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Mar 4, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 54.77%. Comparing base (0448519) to head (5395f27).

Files with missing lines Patch % Lines
bin/prover-client/src/operators/cl_stf.rs 0.00% 19 Missing ⚠️
bin/prover-client/src/rpc_server.rs 0.00% 17 Missing ⚠️
bin/prover-client/src/operators/checkpoint.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   54.77%   54.77%   -0.01%     
==========================================
  Files         317      317              
  Lines       35391    35394       +3     
==========================================
- Hits        19387    19386       -1     
- Misses      16004    16008       +4     
Files with missing lines Coverage Δ
bin/prover-client/src/operators/checkpoint.rs 0.00% <0.00%> (ø)
bin/prover-client/src/rpc_server.rs 0.00% <0.00%> (ø)
bin/prover-client/src/operators/cl_stf.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Commit: 45e10bf

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 59,844
EL_BLOCK 118,411
CL_BLOCK 73,123
CHECKPOINT 2,616

@MdTeach MdTeach force-pushed the refactor/prover-cl-range branch 5 times, most recently from fda1784 to 2a4e0c6 Compare March 6, 2025 11:06
@MdTeach MdTeach force-pushed the refactor/prover-cl-range branch from 2a4e0c6 to 5395f27 Compare March 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant