Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #665

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Update PR template #665

merged 1 commit into from
Feb 12, 2025

Conversation

AaronFeickert
Copy link
Contributor

Description

Not every PR needs new tests. This PR updates the PR template to make this more clear.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

N/A

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

N/A

@AaronFeickert AaronFeickert requested a review from a team as a code owner February 11, 2025 21:33
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.61%. Comparing base (d23d60a) to head (1570504).
Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   54.60%   54.61%           
=======================================
  Files         318      318           
  Lines       34067    34067           
=======================================
+ Hits        18603    18606    +3     
+ Misses      15464    15461    -3     

see 6 files with indirect coverage changes

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1570504

Copy link
Contributor

Commit: 2b82779

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,596
EL_BLOCK 97,975
CL_BLOCK 89,783
L1_BATCH 30,419,814
L2_BATCH 3,566
CHECKPOINT 25,699

@prajwolrg prajwolrg added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit c5a46a9 Feb 12, 2025
21 checks passed
@prajwolrg prajwolrg deleted the pr-template branch February 12, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants