Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Compose Configuration for Prover Client #664

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Feb 11, 2025

Description

  • Added Docker Compose setup for running the prover client.
  • Updated the Docker Compose README with instructions for running the prover.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.61%. Comparing base (d23d60a) to head (5546d28).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   54.60%   54.61%   +0.01%     
==========================================
  Files         318      318              
  Lines       34067    34067              
==========================================
+ Hits        18603    18607       +4     
+ Misses      15464    15460       -4     

see 1 file with indirect coverage changes

@MdTeach MdTeach marked this pull request as ready for review February 11, 2025 19:58
@MdTeach MdTeach requested review from a team as code owners February 11, 2025 19:58
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Commit: 1fedf6d

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,596
EL_BLOCK 97,975
CL_BLOCK 89,783
L1_BATCH 30,419,814
L2_BATCH 3,566
CHECKPOINT 25,699

delbonis
delbonis previously approved these changes Feb 11, 2025
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, looks fine otherwise.

But why were all those lockfiles deleted?

docker/README.md Outdated Show resolved Hide resolved
docker/prover-client/Readme.md Show resolved Hide resolved
@MdTeach MdTeach force-pushed the feat/prover-docker-compose branch from e1adede to ca56ede Compare February 12, 2025 02:47
@MdTeach MdTeach requested a review from delbonis February 12, 2025 02:49
@MdTeach MdTeach force-pushed the feat/prover-docker-compose branch from 88288f0 to cb8474e Compare February 12, 2025 05:24
@MdTeach MdTeach force-pushed the feat/prover-docker-compose branch from cb8474e to 5546d28 Compare February 12, 2025 06:10
@MdTeach MdTeach added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 7095354 Feb 12, 2025
18 checks passed
@MdTeach MdTeach deleted the feat/prover-docker-compose branch February 12, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants