Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitcoinClient add get_block_height rpc method #663

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Feb 11, 2025

Description

  • Adds get_block_height method to BitcoinClient

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@MdTeach MdTeach marked this pull request as ready for review February 11, 2025 10:07
@MdTeach MdTeach requested review from a team as code owners February 11, 2025 10:07
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.73%. Comparing base (95197d3) to head (9a9340e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/btcio/src/rpc/client.rs 0.00% 7 Missing ⚠️
crates/btcio/src/test_utils.rs 0.00% 3 Missing ⚠️
bin/prover-client/src/operators/l1_batch.rs 0.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   54.73%   54.73%   -0.01%     
==========================================
  Files         317      317              
  Lines       33939    33946       +7     
==========================================
+ Hits        18577    18579       +2     
- Misses      15362    15367       +5     
Files with missing lines Coverage Δ
bin/prover-client/src/operators/l1_batch.rs 0.00% <0.00%> (ø)
crates/btcio/src/test_utils.rs 61.45% <0.00%> (-0.65%) ⬇️
crates/btcio/src/rpc/client.rs 84.94% <0.00%> (-0.93%) ⬇️

... and 4 files with indirect coverage changes

@MdTeach MdTeach marked this pull request as draft February 11, 2025 10:17
@MdTeach MdTeach marked this pull request as ready for review February 11, 2025 10:25
Copy link
Contributor

@prajwolrg prajwolrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Did you also try with bip34_block_height?

Copy link
Contributor

Commit: b60eb6b

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,596
EL_BLOCK 97,975
CL_BLOCK 89,783
L1_BATCH 30,419,814
L2_BATCH 3,566
CHECKPOINT 25,699

@MdTeach MdTeach added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit ab6cc42 Feb 11, 2025
18 of 19 checks passed
@MdTeach MdTeach deleted the refactor/btc-get-blk-height branch February 11, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants