-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Str-998: Implement different transaction types for the load testing. #658
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 54.68% 54.66% -0.02%
==========================================
Files 317 317
Lines 33929 33939 +10
==========================================
- Hits 18553 18552 -1
- Misses 15376 15387 +11 |
Commit: 0fb4c7e SP1 Performance Test Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment, not sure if correct:
If we have these solidity contracts in the repo now does that mean that the load testing run requires having a solidity compiler in ci and running it? If so, would it instead be faster to have compiled initcode checked in and deploy from that instead?
@delbonis the load test is disabled for now in the CI. your suggestion makes sense, I think that's a way to go if/when we enable it for the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 812e814
Description
Type of Change
Notes to Reviewers
Apologies for the big change, I tried my best to make it as structured and polished as possible.
Checklist
Related Issues