Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str-961: Introduce load testing env in fn-tests. #639

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

evgenyzdanovich
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich commented Jan 30, 2025

Description

Part of the work related to load testing env. In the follow-ups, the actual load logic is implemented - different types of eth transactions (different eips, deploys, mints, etc)

  • Introduce a separate load testing env in fn-tests.
  • Create a simple basic_load test against the load testing env that sleeps for some time and the load to reth service is generated in the background
  • Currently, the test is disabled, because:
    • logs should be fixed. Currently, there are a lot of debug prints, and it's intended to be used locally.
    • not sure if load tests should be invoked in the CI (maybe periodically?).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (9bae5f8) to head (712a840).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   54.83%   54.82%   -0.01%     
==========================================
  Files         313      313              
  Lines       33526    33526              
==========================================
- Hits        18384    18382       -2     
- Misses      15142    15144       +2     

see 8 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Commit: aaf342c

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,713
EL_BLOCK 98,041
CL_BLOCK 58,268
L1_BATCH 30,387,702
L2_BATCH 5,473
CHECKPOINT 15,255

@evgenyzdanovich evgenyzdanovich force-pushed the str-961-fntests-load-env branch 2 times, most recently from ed53979 to d1cad35 Compare January 31, 2025 15:17
@evgenyzdanovich evgenyzdanovich changed the title Str-961: Introduce a minimal structure for load testing env in fn-tests Str-961: Introduce load testing env in fn-tests. Jan 31, 2025
@evgenyzdanovich evgenyzdanovich marked this pull request as ready for review January 31, 2025 15:52
@evgenyzdanovich evgenyzdanovich requested review from a team as code owners January 31, 2025 15:52
@evgenyzdanovich evgenyzdanovich force-pushed the str-961-fntests-load-env branch from d1cad35 to df2cd5b Compare January 31, 2025 17:26
delbonis
delbonis previously approved these changes Feb 2, 2025
functional-tests/pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 712a840

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit a0d413d Feb 3, 2025
18 of 20 checks passed
@evgenyzdanovich evgenyzdanovich deleted the str-961-fntests-load-env branch February 3, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants