-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zkaleido
repository
#635
Conversation
Commit: 59610ab SP1 Performance Test Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am kinda iffy about the From
implementation for BatchCheckpoint
that gives ProofReceipt
. But the rest looks good to me. And great work on the library!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concur with other comment but looks good otherwise.
ca4f4d0
to
57f7c37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 57f7c37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 3d55fb9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aw now there's a different merge conflict.
3d55fb9
to
c89a90b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c89a90b
Description
This uses the newly created
zkaleido
repository for instead ofstrata-zkvm
andstrata-zkvm-adapters
. There are also some minor updates and removes code duplication.Type of Change
Notes to Reviewers
Checklist
Related Issues