Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mixins for the fn-tests and use in the existing tests. #634

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

evgenyzdanovich
Copy link
Contributor

Description

Introduce mixins for the fn-tests and use in the existing tests.
Also, minor refactoring and cleanup.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@evgenyzdanovich evgenyzdanovich requested a review from a team as a code owner January 24, 2025 22:08
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (0db65b9) to head (d79dab4).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   55.97%   55.95%   -0.03%     
==========================================
  Files         315      315              
  Lines       33428    33428              
==========================================
- Hits        18712    18704       -8     
- Misses      14716    14724       +8     

see 5 files with indirect coverage changes

@evgenyzdanovich evgenyzdanovich force-pushed the str-898-mixins-and-minor-refac branch from 7e47c46 to d79dab4 Compare January 24, 2025 22:36
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Commit: 71fbe49

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,421
EL_BLOCK 98,534
CL_BLOCK 57,370
L1_BATCH 30,387,324
L2_BATCH 5,473
CHECKPOINT 15,895

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 9a52075 Jan 28, 2025
19 checks passed
@evgenyzdanovich evgenyzdanovich deleted the str-898-mixins-and-minor-refac branch January 28, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants