Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport fixes to release #632

Closed
wants to merge 8 commits into from
Closed

Conversation

sapinb
Copy link
Contributor

@sapinb sapinb commented Jan 23, 2025

Description

Backport to release following fixes
#457
#525

Additional fix:
update safe block during initial sync of missing blocks from reth

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

sapinb and others added 3 commits January 23, 2025 17:01
* fix: fullnode sync restart
- l2 block finalization is done only if the l2 block actually exists.
- check point finalization is triggered in cases when we get l1 dablobs
or l1 blocks is received

* docstring: added docstring for handle_checkpoint_finalization and handle_mature_l1_height
@sapinb sapinb requested review from bewakes and purusang January 23, 2025 12:47
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0.99668% with 298 lines in your changes missing coverage. Please review.

Project coverage is 56.42%. Comparing base (a14d926) to head (963c10f).
Report is 36 commits behind head on releases/0.1.0.

Files with missing lines Patch % Lines
crates/consensus-logic/src/fork_choice_manager.rs 0.00% 73 Missing ⚠️
crates/consensus-logic/src/client_transition.rs 0.00% 67 Missing ⚠️
crates/sync/src/simple_sync_worker.rs 0.00% 57 Missing ⚠️
crates/consensus-logic/src/worker.rs 0.00% 55 Missing ⚠️
bin/strata-client/src/main.rs 0.00% 21 Missing ⚠️
crates/consensus-logic/src/sync_manager.rs 0.00% 7 Missing ⚠️
crates/consensus-logic/src/unfinalized_tracker.rs 37.50% 5 Missing ⚠️
crates/btcio/src/reader/query.rs 0.00% 4 Missing ⚠️
bin/strata-client/src/el_sync.rs 0.00% 3 Missing ⚠️
crates/consensus-logic/src/config.rs 0.00% 3 Missing ⚠️
... and 1 more
@@                Coverage Diff                 @@
##           releases/0.1.0     #632      +/-   ##
==================================================
- Coverage           57.16%   56.42%   -0.75%     
==================================================
  Files                 256      265       +9     
  Lines               27048    28294    +1246     
==================================================
+ Hits                15462    15964     +502     
- Misses              11586    12330     +744     
Files with missing lines Coverage Δ
crates/consensus-logic/src/message.rs 0.00% <ø> (ø)
crates/sync/src/worker.rs 0.00% <ø> (ø)
bin/strata-client/src/el_sync.rs 50.00% <0.00%> (ø)
crates/consensus-logic/src/config.rs 0.00% <0.00%> (ø)
crates/state/src/client_state.rs 50.98% <0.00%> (-1.02%) ⬇️
crates/btcio/src/reader/query.rs 31.25% <0.00%> (+31.25%) ⬆️
crates/consensus-logic/src/unfinalized_tracker.rs 91.74% <37.50%> (-1.08%) ⬇️
crates/consensus-logic/src/sync_manager.rs 0.00% <0.00%> (ø)
bin/strata-client/src/main.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/worker.rs 0.00% <0.00%> (ø)
... and 3 more

... and 27 files with indirect coverage changes

Copy link
Contributor

@bewakes bewakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just concerned about the failing CI checks(is that expected?). The rest looks good.

@sapinb
Copy link
Contributor Author

sapinb commented Jan 29, 2025

Sequencer fix needs to branch off from a different point in the release. closing this PR.

@sapinb sapinb closed this Jan 29, 2025
@storopoli storopoli deleted the backport-fcm-messaging-fix branch January 29, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants