Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(make): disable sec for now #603

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Jan 9, 2025

Description

Right now we have several issues with cargo-audit that will be fixed once #542 lands and we have a new release of cargo-audit.

Hence make pr should emulate our GH CI.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

I've updated STR-601 to remember to toggle this back as well once the cargo-audit stuff is fixed.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

@storopoli storopoli requested review from a team as code owners January 9, 2025 09:03
@storopoli storopoli enabled auto-merge January 9, 2025 09:07
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.84%. Comparing base (ed2aba3) to head (4598898).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   56.83%   56.84%           
=======================================
  Files         308      308           
  Lines       32367    32367           
=======================================
+ Hits        18396    18398    +2     
+ Misses      13971    13969    -2     

see 5 files with indirect coverage changes

@storopoli storopoli added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 7a2b4fc Jan 9, 2025
16 of 18 checks passed
@storopoli storopoli deleted the storopoli/make/disable-sec branch January 9, 2025 09:26
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Commit: 372b026

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 7,239,474
EL_BLOCK 100,495
CL_BLOCK 55,340
L1_BATCH 12,460,065
L2_BATCH 5,448
CHECKPOINT 15,322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants