-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-873 SP1-V4 Update #597
Conversation
5b60d30
to
5e180a9
Compare
695e05d
to
bbe0afe
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #597 +/- ##
==========================================
+ Coverage 56.50% 56.82% +0.31%
==========================================
Files 308 308
Lines 32297 32367 +70
==========================================
+ Hits 18251 18394 +143
+ Misses 14046 13973 -73
|
df1b207
to
4e853a4
Compare
3c44c62
to
8453681
Compare
8453681
to
f38e960
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! LGTM!
Does this unblocks us in #542? Cc @evgenyzdanovich |
No, unfortunately, this update doesn’t include the SP1 Rust toolchain update to version 1.82. :( |
Commit: a9969d2 SP1 Performance Test Results
|
With regards to #542, @storopoli they are still addressing that. |
@MdTeach manually checked the perf results against the last merged PR. It seems V4 update even decreases cycle-count a bit, great news! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Updated SP1 to use version 4.0.0-rc.8. This update is required to test proof generation using the SP1 private cluster. We will migrate to the stable version once it is released. Right now, only the release candidate is available.
Type of Change
Notes to Reviewers
Checklist
Related Issues