Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-873 SP1-V4 Update #597

Merged
merged 8 commits into from
Jan 8, 2025
Merged

STR-873 SP1-V4 Update #597

merged 8 commits into from
Jan 8, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Jan 7, 2025

Description

Updated SP1 to use version 4.0.0-rc.8. This update is required to test proof generation using the SP1 private cluster. We will migrate to the stable version once it is released. Right now, only the release candidate is available.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@MdTeach MdTeach requested review from a team as code owners January 7, 2025 20:36
crates/zkvm/adapters/sp1/Cargo.toml Outdated Show resolved Hide resolved
@MdTeach MdTeach force-pushed the STR-764-sp1-v4-update branch from 5b60d30 to 5e180a9 Compare January 8, 2025 03:50
@MdTeach MdTeach requested a review from prajwolrg January 8, 2025 04:01
@john-light john-light changed the title Str-764 SP1-V4 Update Str-873 SP1-V4 Update Jan 8, 2025
@john-light john-light changed the title Str-873 SP1-V4 Update STR-873 SP1-V4 Update Jan 8, 2025
@MdTeach MdTeach force-pushed the STR-764-sp1-v4-update branch from 695e05d to bbe0afe Compare January 8, 2025 07:18
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.82%. Comparing base (c66d479) to head (f38e960).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/zkvm/adapters/sp1/src/host.rs 55.17% 13 Missing ⚠️
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   56.50%   56.82%   +0.31%     
==========================================
  Files         308      308              
  Lines       32297    32367      +70     
==========================================
+ Hits        18251    18394     +143     
+ Misses      14046    13973      -73     
Files with missing lines Coverage Δ
crates/zkvm/adapters/sp1/src/proof.rs 100.00% <ø> (+100.00%) ⬆️
crates/zkvm/adapters/sp1/src/verifier.rs 100.00% <100.00%> (ø)
crates/zkvm/adapters/sp1/src/host.rs 71.03% <55.17%> (+71.03%) ⬆️

... and 7 files with indirect coverage changes

@MdTeach MdTeach force-pushed the STR-764-sp1-v4-update branch 2 times, most recently from df1b207 to 4e853a4 Compare January 8, 2025 09:12
@MdTeach MdTeach marked this pull request as draft January 8, 2025 09:25
@MdTeach MdTeach force-pushed the STR-764-sp1-v4-update branch 2 times, most recently from 3c44c62 to 8453681 Compare January 8, 2025 10:00
@MdTeach MdTeach force-pushed the STR-764-sp1-v4-update branch from 8453681 to f38e960 Compare January 8, 2025 10:54
@MdTeach MdTeach marked this pull request as ready for review January 8, 2025 11:01
Copy link
Contributor

@prajwolrg prajwolrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! LGTM!

@storopoli
Copy link
Member

Does this unblocks us in #542? Cc @evgenyzdanovich

@MdTeach
Copy link
Contributor Author

MdTeach commented Jan 8, 2025

Does this unblocks us in #542? Cc @evgenyzdanovich

No, unfortunately, this update doesn’t include the SP1 Rust toolchain update to version 1.82. :(

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Commit: a9969d2

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 7,239,474
EL_BLOCK 100,495
CL_BLOCK 55,340
L1_BATCH 12,460,065
L2_BATCH 5,448
CHECKPOINT 15,322

@MdTeach MdTeach requested a review from storopoli January 8, 2025 11:50
@evgenyzdanovich
Copy link
Contributor

With regards to #542, @storopoli they are still addressing that.
They recently informed me that somebody is on it (the top priority was to roll out V4 and unblock us with private cluster).

@evgenyzdanovich
Copy link
Contributor

@MdTeach manually checked the perf results against the last merged PR.

It seems V4 update even decreases cycle-count a bit, great news!

Copy link
Contributor

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MdTeach MdTeach added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 22f0e74 Jan 8, 2025
18 checks passed
@MdTeach MdTeach deleted the STR-764-sp1-v4-update branch January 8, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants