-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-950 envelope changes #590
Conversation
b5e3480
to
286799a
Compare
286799a
to
9e770e7
Compare
Commit: c83493b SP1 Performance Test Results
|
54e228e
to
7584ba8
Compare
9e770e7
to
16a2890
Compare
07fc70b
to
cc85da7
Compare
16a2890
to
0528eff
Compare
cc85da7
to
2eda45d
Compare
0528eff
to
727ef1a
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 55.97% 55.73% -0.25%
==========================================
Files 315 315
Lines 33428 33496 +68
==========================================
- Hits 18712 18668 -44
- Misses 14716 14828 +112
|
1fbb9a5
to
037c18f
Compare
3eb992c
to
d7dc0a9
Compare
@delbonis, As discussed in Core sync meeting, I've removed the version from envelope. This should be good to merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d7dc0a9
This PR primarily introduces the following changes:
It still retains version and size of the payload.BundledPayloadEntry
and stores in db, which is ultimately published to bitcoin. Currently, it just does 1-1 mapping like it was before, but the bundling logic can be advanced in future.Type of Change
Notes to Reviewers
Checklist
Related Issues