-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix cargo doc
, add to CI check, and pr
recipe
#297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe remove the compress and archive steps from the workflow file while you're at it.
Otherwise, you can merge this once the CI checks are done (might fail due to the functional tests).
e476862
to
c4fc978
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 64.64% 64.53% -0.11%
==========================================
Files 187 187
Lines 19712 19712
==========================================
- Hits 12742 12722 -20
- Misses 6970 6990 +20
|
c4fc978
to
8540f33
Compare
Hey I've added 0.01% in the code coverage without touching code :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving these changes as the functional tests were already broken. But we might want to merge this once those are fixed and this branch has been rebased.
Description
Type of Change
Checklist
Related Issues
Closes STR-337