Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: logs for btc-notify #55

Merged
merged 2 commits into from
Mar 23, 2025
Merged

chore: logs for btc-notify #55

merged 2 commits into from
Mar 23, 2025

Conversation

storopoli
Copy link
Member

Description

Added a bunch of logs as trace!/debug!/warn!/info!/error! etc to the btc-notify crate.

The in-line comments were really helpful.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update
  • Tracing (logs)

Notes to Reviewers

I think I got most of it right, but let me know if I got something wrong.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

None

@storopoli storopoli requested a review from ProofOfKeags March 7, 2025 19:21
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 93.47826% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.28%. Comparing base (589693b) to head (ba9c454).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/btc-notify/src/state_machine.rs 91.07% 5 Missing ⚠️
crates/btc-notify/src/client.rs 97.22% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (589693b) and HEAD (ba9c454). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (589693b) HEAD (ba9c454)
2 1
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   68.54%   63.28%   -5.27%     
==========================================
  Files         120      137      +17     
  Lines       17668    19572    +1904     
==========================================
+ Hits        12111    12386     +275     
- Misses       5557     7186    +1629     
Files with missing lines Coverage Δ
crates/btc-notify/src/client.rs 99.48% <97.22%> (+0.01%) ⬆️
crates/btc-notify/src/state_machine.rs 95.70% <91.07%> (-0.76%) ⬇️

... and 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rajil1213 Rajil1213 enabled auto-merge March 23, 2025 10:55
@Rajil1213
Copy link
Collaborator

Merging this to keep the ball rolling. We can always add more logs later.

@Rajil1213 Rajil1213 added this pull request to the merge queue Mar 23, 2025
Merged via the queue into main with commit b0ef037 Mar 23, 2025
12 checks passed
@Rajil1213 Rajil1213 deleted the btc-notify-logs branch March 23, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants