Prints Acc tags of tags-tuple at runtime #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetyusufoglu
force-pushed
the
printTagType
branch
2 times, most recently
from
42b5e5a to
6796c92
Compare
psychocoderHPC
requested changes
Oct 8, 2024
include/alpaka/acc/Tag.hpp
Outdated
| void printAccTags() | ||
| { | ||
| // Check if the tuple is empty using std::tuple_size | ||
| if(std::tuple_size<TTuple>{} == 0) |
There was a problem hiding this comment.
done using std::tuple_size_v
include/alpaka/acc/Tag.hpp
Outdated
| else | ||
| { | ||
| std::cout << "Acc Tags: "; | ||
| std::apply([](auto... args) { ((std::cout << args.get_name() << " "), ...); }, TTuple{}); |
There was a problem hiding this comment.
I suggest something like this following code (Not tested) to have a comma seperated list.
std::apply(
[](auto... args) {
auto i = std::size_size_v<TTuple>;
((std::cout << args.get_name() << (--i > 0u ? "," : "")), ...);
},
TTuple{}
);
There was a problem hiding this comment.
ok, good idea
There was a problem hiding this comment.
alternatives exists using make_index_sequence but i preferred this since it is still cleaner. thanks.
SimeonEhrig
reviewed
Oct 8, 2024
mehmetyusufoglu
force-pushed
the
printTagType
branch
2 times, most recently
from
879ce62 to
5bf182f
Compare
mehmetyusufoglu
force-pushed
the
printTagType
branch
from
5bf182f to
511907b
Compare
mehmetyusufoglu
changed the title
SimeonEhrig
approved these changes
Oct 9, 2024
psychocoderHPC
approved these changes
Oct 9, 2024
|
I updated already which CI jobs are required. This PR was created before the last merge where clang10-12 got removed, therefore I merge it with my admin power. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples was exiting silently if there are no enabled backends. This issue is reported by the assistants of the october2024 workshop.
This PR creates a function that prints the Acc-tags of the enabled backends at runtime. If there is no backends, the user is informed.