Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove boost as mandatory dependency #2409

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

psychocoderHPC
Copy link
Member

@psychocoderHPC psychocoderHPC commented Oct 2, 2024

fix #481

Make boost an optional dependency.
alpaka::core::demangled<TYPE> returns a mangled name in case boost is not available. #2405 can solve this but should not be mixed into this PR.
This PR removes the mixing of alpakas own defines e.g BOOST_LANG_HIP which looked like boost but was exposed by alpaka under BOOST names.

This PR is a base for discussion at the next developer meeting. In a separate PR we could reduce the number of tested boost versions. We should also run tests without boost at all.

@psychocoderHPC psychocoderHPC added this to the 2.0.0 milestone Oct 2, 2024
@SimeonEhrig
Copy link
Member

@psychocoderHPC Can you please split up the PR. At least in two PR: remove boost::atomic_ref and the compiler detection.

At the moment it is nearly impossible to review it and I also saw, that you didn't modify the CI, which is definitively useful.

@SimeonEhrig
Copy link
Member

I think also a third PR with the demangling function names is useful.

@psychocoderHPC
Copy link
Member Author

Yes, I can do this after we discuss it in general.

@psychocoderHPC psychocoderHPC marked this pull request as draft October 2, 2024 13:28
@SimeonEhrig
Copy link
Member

Yes, I can do this after we discuss it in general.

You got me. I didn't read the description until the end 😬

@SimeonEhrig
Copy link
Member

@psychocoderHPC Can you please short summarize the main changes?

If I'm not wrong the following boost features are used:

  • preprocessor defines for compiler detection
  • boost::atomic_ref if std::atomic_ref is not avaible
  • demangle type names

Did I missed something?

@psychocoderHPC
Copy link
Member Author

@psychocoderHPC Can you please short summarize the main changes?

If I'm not wrong the following boost features are used:

  • preprocessor defines for compiler detection
  • boost::atomic_ref if std::atomic_ref is not avaible
  • demangle type names

Did I missed something?

no thats a good summery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Core Boost Dependency
2 participants