1D Convolution example #2220
Merged
1D Convolution example #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
from
6e789a4 to
8286036
Compare
|
@mehmetyusufoglu A hint, you can use a draft instead a pull request, if you nobody should merge to early. There is option on the right corner to covert the PR to a draft.
|
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
4 times, most recently
from
34039a1 to
afb11ce
Compare
mehmetyusufoglu
changed the title
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
from
11ca997 to
3901fcc
Compare
SimeonEhrig
reviewed
Jan 22, 2024
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
2 times, most recently
from
acaaf9e to
c7665f3
Compare
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
3 times, most recently
from
39546d8 to
a531e69
Compare
psychocoderHPC
requested changes
Jan 22, 2024
| nativeOutputDeviceMemory, | ||
| inputSize, | ||
| filterSize); | ||
| alpaka::wait(queue); |
There was a problem hiding this comment.
no wait is required because the next operation is in the same queue
There was a problem hiding this comment.
ok I added wait after the second operation. Thanks a lot.
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
3 times, most recently
from
6025f69 to
1920952
Compare
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
2 times, most recently
from
d844f28 to
7343be9
Compare
bernhardmgruber
previously approved these changes
Jan 24, 2024
mehmetyusufoglu
force-pushed
the
convolutionExample
branch
from
7343be9 to
d37cad5
Compare
bernhardmgruber
approved these changes
Jan 25, 2024
psychocoderHPC
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consisting 1D convolution implementation is an exercise for a 2D or 3D convolution example.