Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ROCm CI tests for version 5.6, 5.7 #2207

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

SimeonEhrig
Copy link
Member

@SimeonEhrig SimeonEhrig commented Dec 18, 2023

fix #1996

  • Update script to install HIP.
    • update environment variables
    • update installed packages
  • update CMake max HIP version to 5.7
  • fix wrong variable usage to find rocrand

@SimeonEhrig SimeonEhrig mentioned this pull request Dec 18, 2023
@SimeonEhrig
Copy link
Member Author

The install_hip.sh script is broken.

@psychocoderHPC
Copy link
Member

The problem is that install_hip.sh assumes that the rocm container will be used but the CI is using the alpaka base container.

@psychocoderHPC
Copy link
Member

I pushed an update of the hip install script to support alpaka's base CI container

@psychocoderHPC psychocoderHPC force-pushed the addROCmCITest5.6-6.0 branch 8 times, most recently from 0566446 to 15d79e9 Compare December 19, 2023 16:08
@SimeonEhrig
Copy link
Member Author

@psychocoderHPC Maybe you can reduce the amount hip packages to install. See alpaka container: https://codebase.helmholtz.cloud/crp/alpaka-group-container/-/blob/master/generator/rocm.py?ref_type=heads#L75

@psychocoderHPC psychocoderHPC force-pushed the addROCmCITest5.6-6.0 branch 8 times, most recently from c244acf to d4bb383 Compare December 20, 2023 11:17
SimeonEhrig and others added 3 commits December 20, 2023 12:34
- Update install script to fully install HIP.
  - update environment variables
- update CMake max HIP version to 5.7
- fix wrong variable usage to find `rocrand`
@psychocoderHPC psychocoderHPC changed the title add ROCm CI tests for version 5.6, 5.7 and 6.0 add ROCm CI tests for version 5.6, 5.7 Dec 20, 2023
@psychocoderHPC
Copy link
Member

I updated the PR to test only ROCM 5.6 and 5.7

ROCm 6.0 will be a separate PR.

@psychocoderHPC psychocoderHPC mentioned this pull request Dec 20, 2023
1 task
@SimeonEhrig
Copy link
Member Author

The changes looks good but I cannot approve because I opened the PR 😅

@psychocoderHPC
Copy link
Member

maybe @fwyzard will press the merge button.

@fwyzard
Copy link
Contributor

fwyzard commented Dec 20, 2023

I was waiting for the tests to complete :-)

@fwyzard fwyzard merged commit 3503d42 into alpaka-group:develop Dec 20, 2023
22 checks passed
This was referenced Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support ROCm 5.6
3 participants