Merge pull request #27 from alpaca-tc/fixed-25

Render the number of sources
alpaca-tc · May 9, 2024 · 2ba2468 · 2ba2468
2 parents fbab5e0 + 1d00548
commit 2ba2468
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 1 deletion.
diff --git a/frontend/models/definition.ts b/frontend/models/definition.ts
@@ -2,4 +2,5 @@ export type Definition = {
   id: number
   definitionGroup: string | null
   title: string
+  sourcesCount: number
 }
diff --git a/frontend/pages/DefinitionList/components/DefinitionList/List.tsx b/frontend/pages/DefinitionList/components/DefinitionList/List.tsx
@@ -85,7 +85,7 @@ export const List = forwardRef<HTMLLIElement, Props>((props, ref) => {
 
           items.push({
             key: `definition-${definition.id}`,
-            title: definition.title,
+            title: `(${definition.sourcesCount}) ${definition.title}`,
             isSelected,
             onClick: onClickDefinition,
             prefix: (

diff --git a/frontend/repositories/definitionListRepository.ts b/frontend/repositories/definitionListRepository.ts
@@ -12,6 +12,7 @@ type DefinitionReponse = {
   id: number
   definition_group: string | null
   title: string
+  sources_count: number
 }
 
 type DefinitionsResponse = {
@@ -47,6 +48,7 @@ export const useDefinitionList = (
       id: definition.id,
       definitionGroup: definition.definition_group,
       title: definition.title,
+      sourcesCount: definition.sources_count,
     }))
   }, [])
 

diff --git a/lib/diver_down/web/action.rb b/lib/diver_down/web/action.rb
@@ -130,6 +130,7 @@ def definitions(page:, per:, title:, source:, definition_group:)
               id: definition.store_id,
               definition_group: definition.definition_group,
               title: definition.title,
+              sources_count: definition.sources.size,
             }
           end,
           pagination: pagination.to_h

diff --git a/spec/diver_down/web_spec.rb b/spec/diver_down/web_spec.rb
@@ -78,6 +78,7 @@ def app
             'id' => 1,
             'title' => 'title',
             'definition_group' => nil,
+            'sources_count' => 1,
           },
         ],
         'pagination' => {