Fix pass through of arguments that include spaces #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnivet
added a commit
to avanteam/win-shim
that referenced
this pull request
Jun 28, 2023
To release a pre-version while waiting an official one if PR is accepted aloneguid#8
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not expected but I’ve take the time to fix #7 since I’ve found another issue for which I’ve had no workaround : Arguments that contain spaces where not correctly transmitted.
Instead of being send as a single argument they were send as multiple arguments since they were not encapsulated into double quotes.
NB : There is probably still some issues if an argument include spaces, and ends with a backslash or contains a backslash followed by a double quotes, because there is an awkward logic in command line parsing based on the parity of backslashes before a double quote that has always be hard to manage and understand for me (see :
https://web.archive.org/web/20220604063845/https://docs.microsoft.com/en-us/previous-versions//17w5ykft(v=vs.85)?redirectedfrom=MSDN)