Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#407 added option to reduce flushing of streams during write operation. #432

Merged
merged 2 commits into from
Dec 22, 2023
Merged

#407 added option to reduce flushing of streams during write operation. #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04216ea
#407 added option to reduce flushing of streams during write operation.
Nov 19, 2023
3016ee8
adding my suggesions to include this change in 4.18 release, hope you…
aloneguid Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Parquet/File/DataColumnWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ private async Task CompressAndWriteAsync(
ph.Write(new Meta.Proto.ThriftCompactProtocolWriter(headerMs));
int headerSize = (int)headerMs.Length;
headerMs.Position = 0;
_stream.Flush();
// there used to be a flush here, but removed in #432 due to excessive flushing on expensive streams

await headerMs.CopyToAsync(_stream);

// write data
Expand Down
1 change: 1 addition & 0 deletions src/Parquet/ParquetOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ namespace Parquet {
/// Parquet options
/// </summary>
public class ParquetOptions {

/// <summary>
/// When true byte arrays will be treated as UTF-8 strings on read
/// </summary>
Expand Down
Loading